> On March 7, 2013, 8:17 a.m., Benjamin Hindman wrote: > > src/slave/process_based_isolation_module.cpp, lines 331-332 > > <https://reviews.apache.org/r/9795/diff/1/?file=267811#file267811line331> > > > > s/descendant/child/ and s/ancestor/parent/?
Went with parent and descendant. > On March 7, 2013, 8:17 a.m., Benjamin Hindman wrote: > > src/slave/process_based_isolation_module.cpp, line 344 > > <https://reviews.apache.org/r/9795/diff/1/?file=267811#file267811line344> > > > > If we ever start to integrate some of the monitoring into the webui it > > would be swell to be able to play with it on our laptops. For that, I > > suggest some os::shell calls here. See src/scripts/killtree.sh for > > inspiration (I could even imagine a minor refactor of killtree.sh so you > > can easily just print all pids in the tree without actually killing them, > > i.e., by sending them a CONT signal or 0). Agreed, I'm planning on implementing an OSX proc interface. Maybe that interface shells out as you said, but I was planning on doing it programmatically. > On March 7, 2013, 8:17 a.m., Benjamin Hindman wrote: > > src/slave/process_based_isolation_module.cpp, line 307 > > <https://reviews.apache.org/r/9795/diff/1/?file=267811#file267811line307> > > > > Adding on to a comment in another review, this would then be > > 'proc::status(info->pid)' which sounds good to me and a /proc/[pid]/status > > actually exists and is just the prettyfied version of /proc/[pid]/status. Done in the earlier review. I find it easier to linearly progress through the reviews, so adding comments like this in the right review helps me a lot! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9795/#review17522 ----------------------------------------------------------- On March 7, 2013, 3:18 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9795/ > ----------------------------------------------------------- > > (Updated March 7, 2013, 3:18 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See subject. > > > This addresses bug MESOS-370. > https://issues.apache.org/jira/browse/MESOS-370 > > > Diffs > ----- > > src/slave/process_based_isolation_module.cpp > ff98d105af675dfc66070feaa43b42c1aa438fd8 > > Diff: https://reviews.apache.org/r/9795/diff/ > > > Testing > ------- > > make check and added tests in a subsequent review > > > Thanks, > > Ben Mahler > >
