-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9887/
-----------------------------------------------------------
(Updated March 19, 2013, 9:49 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Upon further review, I realized that its not actually guaranteed that
resourcesChanged will be called three times, no matter how long we wait,
depending on how the slave is implemented, so since we don't actually care how
many times it gets called in this test anyways (what's important is that the
task gets launched and killed, which we have expectations for) its better to
leave the test flexible and not specify the number of times we expect
resourcesChanged to be called.
Description
-------
In the TaskFinished unit test, TestingIsolationModule::resourcesChanged should
be called three times - once each for the two tasks that are launched, and once
for the task that is killed. The way the test was written before, we were only
expecting 2 calls, and since the call resulting from the task being killed
usually didn't happen before the test was shut down this worked most but not
all of the time, causing occasional flakiness. This patch changes it to expect
3 calls and adds a trigger so that we wait until the third call happens before
shutting down the test.
This addresses bug MESOS-386.
https://issues.apache.org/jira/browse/MESOS-386
Diffs (updated)
-----
src/tests/allocator_tests.cpp 4ae8bfd
Diff: https://reviews.apache.org/r/9887/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
