-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9887/
-----------------------------------------------------------
(Updated March 20, 2013, 5:40 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
additional testing
Description
-------
In the TaskFinished unit test, TestingIsolationModule::resourcesChanged should
be called three times - once each for the two tasks that are launched, and once
for the task that is killed. The way the test was written before, we were only
expecting 2 calls, and since the call resulting from the task being killed
usually didn't happen before the test was shut down this worked most but not
all of the time, causing occasional flakiness. This patch changes it to expect
3 calls and adds a trigger so that we wait until the third call happens before
shutting down the test.
This addresses bug MESOS-386.
https://issues.apache.org/jira/browse/MESOS-386
Diffs
-----
src/tests/allocator_tests.cpp 4ae8bfd
Diff: https://reviews.apache.org/r/9887/diff/
Testing (updated)
-------
make check
./bin/mesos-tests.sh --gtest_filter=*TaskFinished* --gtest_repeat=300
--gtest_break_on_failure
Thanks,
Thomas Marshall
