----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10345/#review18796 -----------------------------------------------------------
third_party/libprocess/third_party/stout/include/stout/os.hpp <https://reviews.apache.org/r/10345/#comment39236> s/HLEN/HOST_NAME_MAX to match what the man page says. third_party/libprocess/third_party/stout/include/stout/os.hpp <https://reviews.apache.org/r/10345/#comment39237> I'm unaware of the context behind this double lookup. So I will let BenH comment on it. - Vinod Kone On April 8, 2013, 9:19 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10345/ > ----------------------------------------------------------- > > (Updated April 8, 2013, 9:19 p.m.) > > > Review request for mesos. > > > Description > ------- > > This patch simplifies os::hostname() in libstout. The call to os::hostname() > would take the result of `gethostname()' and then do a DNS lookup on the > result (presumably to ensure the hosts file is set correctly). This patch > drops the DNS lookup. > > > Diffs > ----- > > third_party/libprocess/third_party/stout/include/stout/os.hpp 5c21783 > > Diff: https://reviews.apache.org/r/10345/diff/ > > > Testing > ------- > > Works on our production Hadoop cluster at airbnb. > > > Thanks, > > Brenden Matthews > >
