----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11108/#review21393 -----------------------------------------------------------
I'd recommend adding benh as a reviewer on this as I don't know the context behind os::hostname. - Ben Mahler On June 3, 2013, 9:10 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11108/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 9:10 p.m.) > > > Review request for mesos. > > > Description > ------- > > Simplify os::hostname() in libstout. > > Review: https://reviews.apache.org/r/11108 > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5 > > Diff: https://reviews.apache.org/r/11108/diff/ > > > Testing > ------- > > Used in production at airbnb. > > `make check' > > > Thanks, > > Brenden Matthews > >
