> On April 5, 2013, 6:25 p.m., Benjamin Hindman wrote: > > src/launcher/launcher.cpp, line 307 > > <https://reviews.apache.org/r/10286/diff/1/?file=277905#file277905line307> > > > > Is every distribution of tar smart enough to not need 'z'? > > Vinod Kone wrote: > The modern tar, afaict. > http://askubuntu.com/questions/92328/how-do-i-uncompress-a-tarball-that-uses-xz/107976#107976 > > Ben Mahler wrote: > Whoops, replying on the review instead of email: > > From the same link: > > "It's a feature of GNU tar. I don't know about competing implementations, > but GNU tar should be the most relevant to ubuntu. > gnu.org/software/tar/manual/tar.html#SEC131" > > So we probably don't want to make that assumption, unless BSD tar also > handles this? It's probably better to be explicit anyway.
done. made it explicit. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10286/#review18717 ----------------------------------------------------------- On April 4, 2013, 6:12 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10286/ > ----------------------------------------------------------- > > (Updated April 4, 2013, 6:12 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > hadoop/TUTORIAL.sh b0f77f3be622ed103778b165e906523430e8144a > src/launcher/launcher.cpp eb8d6fb48c571ca10a7a057667b503e2723beef3 > > Diff: https://reviews.apache.org/r/10286/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
