> On April 5, 2013, 6:25 p.m., Benjamin Hindman wrote: > > src/launcher/launcher.cpp, line 307 > > <https://reviews.apache.org/r/10286/diff/1/?file=277905#file277905line307> > > > > Is every distribution of tar smart enough to not need 'z'? > > Vinod Kone wrote: > The modern tar, afaict. > http://askubuntu.com/questions/92328/how-do-i-uncompress-a-tarball-that-uses-xz/107976#107976 > > Ben Mahler wrote: > Whoops, replying on the review instead of email: > > From the same link: > > "It's a feature of GNU tar. I don't know about competing implementations, > but GNU tar should be the most relevant to ubuntu. > gnu.org/software/tar/manual/tar.html#SEC131" > > So we probably don't want to make that assumption, unless BSD tar also > handles this? It's probably better to be explicit anyway. > > Vinod Kone wrote: > done. made it explicit.
Thank you! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10286/#review18717 ----------------------------------------------------------- On April 8, 2013, 11:18 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10286/ > ----------------------------------------------------------- > > (Updated April 8, 2013, 11:18 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > hadoop/TUTORIAL.sh b0f77f3be622ed103778b165e906523430e8144a > src/Makefile.am 0de362e4b0cd8a2bc771facfc7cce17cbe8d8fd5 > src/launcher/launcher.cpp eb8d6fb48c571ca10a7a057667b503e2723beef3 > src/master/frameworks_manager.hpp PRE-CREATION > src/master/frameworks_manager.cpp PRE-CREATION > src/slave/cgroups_isolator.hpp eaabf432be5417905b22bae6b9ddbee70406a990 > src/slave/cgroups_isolator.cpp d31c2a50787058edb99c2b8070446ead128dc79e > src/slave/flags.hpp f3cbe3d5b633e149a349c4ec9784ac5ebfbd4325 > src/tests/cluster.hpp 7cc97518120dfa9b5e82826ed0240e57a28be4c2 > src/tests/files_tests.cpp dbb4d26a3082d083950b5f371a132628912f6c04 > src/tests/isolator.hpp f885ccb44e809383e658f45d9a03eda174cf2d72 > src/tests/master_tests.cpp 05cc8a7102d3223ac284ad0bdf4b3c8e3452fa8a > src/tests/monitor_tests.cpp eb5bb73ce96ac11b76dc288834087c06964343fe > src/tests/reaper_tests.cpp 2c37e405db19a12270b47488dcc31e99628c9d3e > src/tests/state_tests.cpp 1b3acf78fab4b9bb4c804698c8354c8d0f60cbcb > src/tests/utils.hpp 9fee0ca68d4a0c307e875a7e520fd00c5f9a7b57 > third_party/libprocess/include/process/gmock.hpp > a8cab4c5bab689dfa10b8bd5c997ac6e1df56d24 > third_party/libprocess/src/tests/process_tests.cpp > 53ade66c9d2dad8ffed2d322665291566acb4c84 > third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp > 4351f8028007fabee7aa28389de91c28d64213fe > > Diff: https://reviews.apache.org/r/10286/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
