> On April 9, 2013, 4:13 p.m., Benjamin Hindman wrote: > > src/slave/gc.hpp, line 94 > > <https://reviews.apache.org/r/10028/diff/5/?file=279123#file279123line94> > > > > Hmm, better location for the comment but honestly I would still put it > > next to the actual removal operation. The meat of this TODO is really: do > > the actual removal asynchronously from the GarbageCollectorProcess.
Agreed, and done. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10028/#review18856 ----------------------------------------------------------- On April 8, 2013, 11:52 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10028/ > ----------------------------------------------------------- > > (Updated April 8, 2013, 11:52 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. This was needed in order to write a fix for MESOS-396. > > > This addresses bug MESOS-396. > https://issues.apache.org/jira/browse/MESOS-396 > > > Diffs > ----- > > src/slave/gc.hpp 605957c686efd8e50ee5dfd61de51e192d34ac92 > src/slave/gc.cpp c40f42a78457318a7968a6d50bb06632f289db05 > src/tests/gc_tests.cpp 037fe096179596a6bb9359b4258c2afafee300f9 > > Diff: https://reviews.apache.org/r/10028/diff/ > > > Testing > ------- > > Added missing and new unit tests. > > Also ran the tests with 300 iterations. > > > Thanks, > > Ben Mahler > >
