> On March 25, 2013, 2:17 a.m., Benjamin Hindman wrote: > > src/slave/gc.hpp, line 64 > > <https://reviews.apache.org/r/10028/diff/3/?file=273944#file273944line64> > > > > I don't think this TODO should be here. As far as the API is concerned, > > you're returning a Future exactly because you might block. If there is a > > way to optimize 'unschedule' then you should put that TODO there.
+1 - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10028/#review18334 ----------------------------------------------------------- On March 22, 2013, 11:54 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10028/ > ----------------------------------------------------------- > > (Updated March 22, 2013, 11:54 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. This was needed in order to write a fix for MESOS-396. > > > This addresses bug MESOS-396. > https://issues.apache.org/jira/browse/MESOS-396 > > > Diffs > ----- > > src/slave/gc.hpp c5cceb13b907c222fc177f1bdeeb838ba8efcc4e > src/slave/gc.cpp 92ea79c126f0852a9aeaacd51e7261962f56b8d1 > src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab > > Diff: https://reviews.apache.org/r/10028/diff/ > > > Testing > ------- > > Added missing and new unit tests. > > Also ran the tests with 300 iterations. > > > Thanks, > > Ben Mahler > >
