> On April 9, 2013, 7:56 p.m., Ben Mahler wrote: > > third_party/libprocess/third_party/stout/tests/os_tests.cpp, line 205 > > <https://reviews.apache.org/r/10231/diff/3/?file=279778#file279778line205> > > > > Why not ASSERT_LE?
The assumption was that some time must have elapsed between the measurement of the time and the sleep itself, but there is no reason ASSERT_LE can't be used. So I changed it to ASSERT_LE. > On April 9, 2013, 7:56 p.m., Ben Mahler wrote: > > third_party/libprocess/configure.ac, line 104 > > <https://reviews.apache.org/r/10231/diff/3/?file=279776#file279776line104> > > > > Curious.. why did the need for this only surface now? Because stout tests were compiled separately and previously no (stout) tests were using the rt library? - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10231/#review18877 ----------------------------------------------------------- On April 9, 2013, 7:28 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10231/ > ----------------------------------------------------------- > > (Updated April 9, 2013, 7:28 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > This is part 1. > Part 2 would be to replace sleep() call in Mesos to use os::sleep(). > > > This addresses bug MESOS-415. > https://issues.apache.org/jira/browse/MESOS-415 > > > Diffs > ----- > > third_party/libprocess/configure.ac > cb7f0d73c6ddc1e75f7a3120858362c56a003aa7 > third_party/libprocess/third_party/stout/include/stout/os.hpp > 5c217836a4a60402945544cba862b4c936ff0f83 > third_party/libprocess/third_party/stout/tests/os_tests.cpp > d543b6d585097fbd6ee455d4807f23eb3b532a23 > > Diff: https://reviews.apache.org/r/10231/diff/ > > > Testing > ------- > > Ran make check and > ./mesos/build/third_party/libprocess/third_party/stout-tests > --gtest_filter="OsTest.sleep" --gtest_repeat=500 > > > Thanks, > > Jiang Yan Xu > >
