----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10231/#review18899 -----------------------------------------------------------
Ship it! third_party/libprocess/configure.ac <https://reviews.apache.org/r/10231/#comment39367> s/hpp/hpp./ In general, all of our comments ends with periods. third_party/libprocess/third_party/stout/tests/os_tests.cpp <https://reviews.apache.org/r/10231/#comment39368> Instead of storing the duration here, this can be just one line: ASSERT_ERROR(os::sleep(Milliseconds(-10)); - Ben Mahler On April 9, 2013, 10:25 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10231/ > ----------------------------------------------------------- > > (Updated April 9, 2013, 10:25 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > This is part 1. > Part 2 would be to replace sleep() call in Mesos to use os::sleep(). > > > This addresses bug MESOS-415. > https://issues.apache.org/jira/browse/MESOS-415 > > > Diffs > ----- > > third_party/libprocess/configure.ac > cb7f0d73c6ddc1e75f7a3120858362c56a003aa7 > third_party/libprocess/third_party/stout/include/stout/os.hpp > 5c217836a4a60402945544cba862b4c936ff0f83 > third_party/libprocess/third_party/stout/tests/os_tests.cpp > d543b6d585097fbd6ee455d4807f23eb3b532a23 > > Diff: https://reviews.apache.org/r/10231/diff/ > > > Testing > ------- > > Ran make check and > ./mesos/build/third_party/libprocess/third_party/stout-tests > --gtest_filter="OsTest.sleep" --gtest_repeat=500 > > > Thanks, > > Jiang Yan Xu > >
