----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10142/#review19027 -----------------------------------------------------------
src/slave/slave.hpp <https://reviews.apache.org/r/10142/#comment39549> kill unused states. src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39538> Comment s/Not killing/Ignoring/ src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39539> Remove the task from executor's queued tasks src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39540> Ignoring src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39541> add a CHECK(RUNNING) here src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39542> checks src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39543> checks src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39544> check for non null pid src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39546> Verify and change the semantics of how we do SUM.update() w/ and w/o checkpoint. src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39547> check states..here and everywhere else src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39548> s/TERMINATED/TERMINATING/ src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39550> Change this to CHECK(!terminated) - Vinod Kone On April 9, 2013, 8:58 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10142/ > ----------------------------------------------------------- > > (Updated April 9, 2013, 8:58 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > This is based off https://reviews.apache.org/r/10112. > > Also fixed TODOs and other misc stuff from the above review. > > > Diffs > ----- > > src/slave/isolator.hpp d702041784f5db159efd7da4d916405e86d99741 > src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 > src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa > src/slave/status_update_manager.hpp > e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24 > src/slave/status_update_manager.cpp > 044d245f370ef23ddc67fadbf7f8fe9d75dd662a > src/tests/isolator.hpp f885ccb44e809383e658f45d9a03eda174cf2d72 > > Diff: https://reviews.apache.org/r/10142/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
