----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10142/#review19274 -----------------------------------------------------------
Ship it! src/slave/slave.hpp <https://reviews.apache.org/r/10142/#comment39921> Point out that this implies the framework is shutting down everywhere. src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39919> Log the fact of whether we could remove it from the queued tasks for the executor. If we can't then the WARNING should be logged as before. src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39920> WARNING? src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39922> s/This/TERMINATED/ s/double// and "runs the executor driver in a child process" src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39923> Ditto src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39925> Comment as to how this state is possible. src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39926> Add an explicit case for TERMINATED that falls through to default. src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39927> Can you remove this for me? Ditto for _unwatch :) src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39928> This needs to check discarded if we remove the CHECK. src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39931> model this after the switch style in json.hpp src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39930> kill breaks in these src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39929> either default or this, but not both src/slave/slave.cpp <https://reviews.apache.org/r/10142/#comment39932> ditto - Ben Mahler On April 15, 2013, 11:54 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10142/ > ----------------------------------------------------------- > > (Updated April 15, 2013, 11:54 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > This is based off https://reviews.apache.org/r/10112. > > Also fixed TODOs and other misc stuff from the above review. > > > Diffs > ----- > > src/slave/isolator.hpp d702041784f5db159efd7da4d916405e86d99741 > src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 > src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa > src/slave/status_update_manager.hpp > e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24 > src/slave/status_update_manager.cpp > 044d245f370ef23ddc67fadbf7f8fe9d75dd662a > src/tests/isolator.hpp f885ccb44e809383e658f45d9a03eda174cf2d72 > src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e > > Diff: https://reviews.apache.org/r/10142/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
