----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10422/#review19042 -----------------------------------------------------------
third_party/libprocess/third_party/stout/include/stout/duration.hpp <https://reviews.apache.org/r/10422/#comment39570> s/rhs/that s/ &/& / third_party/libprocess/third_party/stout/include/stout/duration.hpp <https://reviews.apache.org/r/10422/#comment39575> What overflow case are you worried about? With doubles this will take some effort to overflow, so I'd say to kill this TODO. third_party/libprocess/third_party/stout/include/stout/duration.hpp <https://reviews.apache.org/r/10422/#comment39571> ditto third_party/libprocess/third_party/stout/include/stout/duration.hpp <https://reviews.apache.org/r/10422/#comment39572> s/ &/& / third_party/libprocess/third_party/stout/include/stout/duration.hpp <https://reviews.apache.org/r/10422/#comment39574> A one liner here would be: return Seconds(lhs.secs() + rhs.secs()); But I'm ok with how you re-use the += operator here. The other problem with my one-liner is that it will need to become the following when we use an integral value: return Nanoseconds(lhs.ns() + rhs.ns()); So I like your solution, just wanted to share my observation. third_party/libprocess/third_party/stout/include/stout/duration.hpp <https://reviews.apache.org/r/10422/#comment39573> ditto third_party/libprocess/third_party/stout/tests/duration_tests.cpp <https://reviews.apache.org/r/10422/#comment39569> Instead of further expanding on "Test", can you pull out the added stuff into a "Arithmetic" test? Likewise, if you're up for cleaning this up a bit, you can split up "Test" into both "Parse" and "Comparison" tests. - Ben Mahler On April 11, 2013, 6:27 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10422/ > ----------------------------------------------------------- > > (Updated April 11, 2013, 6:27 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > third_party/libprocess/third_party/stout/include/stout/duration.hpp > ebebd6b9ac3fe18ce06aa1bfa831f299c7c88663 > third_party/libprocess/third_party/stout/tests/duration_tests.cpp > c8d9bbe4c5b1396d2cf6afca2d6bf30e36815c48 > > Diff: https://reviews.apache.org/r/10422/diff/ > > > Testing > ------- > > make check GTEST_FILTER="DurationTest.Test" > > > Thanks, > > Jiang Yan Xu > >
