----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10422/#review19238 -----------------------------------------------------------
Ship it! third_party/libprocess/third_party/stout/tests/duration_tests.cpp <https://reviews.apache.org/r/10422/#comment39855> s/ / / third_party/libprocess/third_party/stout/tests/duration_tests.cpp <https://reviews.apache.org/r/10422/#comment39854> These can all be inline: stringify(Seconds(3.14159265358979323)) third_party/libprocess/third_party/stout/tests/duration_tests.cpp <https://reviews.apache.org/r/10422/#comment39853> If the compiler allows more digits than representable in the literal, let's do that. Otherwise: #include <math.h> // For M_PI defined by POSIX. - Ben Mahler On April 15, 2013, 10:44 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10422/ > ----------------------------------------------------------- > > (Updated April 15, 2013, 10:44 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > third_party/libprocess/third_party/stout/include/stout/duration.hpp > ebebd6b9ac3fe18ce06aa1bfa831f299c7c88663 > third_party/libprocess/third_party/stout/tests/duration_tests.cpp > c8d9bbe4c5b1396d2cf6afca2d6bf30e36815c48 > > Diff: https://reviews.apache.org/r/10422/diff/ > > > Testing > ------- > > make check GTEST_FILTER="DurationTest.*" > > > Thanks, > > Jiang Yan Xu > >
