> On April 16, 2013, 12:46 a.m., Vinod Kone wrote: > > src/tests/environment.cpp, line 71 > > <https://reviews.apache.org/r/10531/diff/1/?file=281408#file281408line71> > > > > I wonder if we can skip the test from within the test or test fixture. > > > > Mainly because absence of hierarchies at the very beginning of tests, > > doesn't necessarily mean there are no hierarchies when the no hierarchy > > test is run.
It would certainly be possible to skip the tests logic from within the test fixture. The only problem with this is that gtest will show that the test succeeded even though it really didn't, since as far as I know there's no way to disable a test after it has already started to run or to return any test status except succeed or fail. This isn't really a big deal, since we would still have the error message get printed, so I'll implement it that way if I don't get anymore feedback. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10531/#review19232 ----------------------------------------------------------- On April 16, 2013, 12:32 a.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10531/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 12:32 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > I know that I'm not assigned to this issue, but its causing about 75% of the > test failures that we're seeing in the AMP lab's Jenkins now, so I figured I > would tackle it: > > > This addresses bug MESOS-414. > https://issues.apache.org/jira/browse/MESOS-414 > > > Diffs > ----- > > src/tests/environment.cpp 3096e5a > > Diff: https://reviews.apache.org/r/10531/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
