> On April 16, 2013, 9:06 p.m., Ben Mahler wrote: > > src/tests/environment.cpp, line 59 > > <https://reviews.apache.org/r/10531/diff/2/?file=281602#file281602line59> > > > > Why the TODO? This is already checked inside the > > CgroupsNoHierarchyTest::SetUpTestCase..?
Vinod asked for the TODO in an earlier comment. You're right that we already check right before the test is run, in SetUpTestCase, but Vinod's point is that it would be ideal if we could get rid of this check in environment and just disable the test right before it runs. I'll leave off the TODO for now. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10531/#review19271 ----------------------------------------------------------- On April 16, 2013, 6:40 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10531/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 6:40 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > I know that I'm not assigned to this issue, but its causing about 75% of the > test failures that we're seeing in the AMP lab's Jenkins now, so I figured I > would tackle it: > > > This addresses bug MESOS-414. > https://issues.apache.org/jira/browse/MESOS-414 > > > Diffs > ----- > > src/tests/cgroups_tests.cpp 34ae0d2 > src/tests/environment.cpp 3096e5a > > Diff: https://reviews.apache.org/r/10531/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
