----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10534/#review19269 -----------------------------------------------------------
src/master/http.cpp <https://reviews.apache.org/r/10534/#comment39889> I liked activated and deactivated because they are complementary. any particular reason you chose connected? src/master/master.cpp <https://reviews.apache.org/r/10534/#comment39888> How is this possible? A comment would be great. src/master/master.cpp <https://reviews.apache.org/r/10534/#comment39890> I wonder if we should even allow a deactivated slave to register? Thoughts? src/master/master.cpp <https://reviews.apache.org/r/10534/#comment39891> s/Delete it/Add to deactivated/ src/master/master.cpp <https://reviews.apache.org/r/10534/#comment39892> I know this code preceded you, but what is the intention behind add this slave to deactivated? Can a slave be removed even when it is not deactivated? If no, looks like you already insert it in Master::deactivate()? - Vinod Kone On April 16, 2013, 12:58 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10534/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 12:58 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This simplifies the master state. > > > Diffs > ----- > > src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed > src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 > src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c > src/webui/master/static/controllers.js > 0f9573b3e325e4ca9ff9ea1467c1815ea16c0fa1 > src/webui/master/static/home.html 847d1b687f1d5a6f11e60b81741d4e22104eddf8 > > Diff: https://reviews.apache.org/r/10534/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
