> On April 16, 2013, 6:50 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 1780 > > <https://reviews.apache.org/r/10534/diff/1/?file=281437#file281437line1780> > > > > I wonder if we should even allow a deactivated slave to register? > > Thoughts?
This was incorrectly based on the slave id, I've changed this to be keyed on the UPID of the slave. > On April 16, 2013, 6:50 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 1957 > > <https://reviews.apache.org/r/10534/diff/1/?file=281437#file281437line1957> > > > > I know this code preceded you, but what is the intention behind add > > this slave to deactivated? > > > > Can a slave be removed even when it is not deactivated? > > If no, looks like you already insert it in Master::deactivate()? removeSlave is called from: deactivateSlave() // Slave is not responding. unregisterSlave() // Slave asked to unregister. exited() // When the slave exits and is not checkpointing. Deactivating in all cases above denies re-registration until another registration takes place. Meaning whenever the master removes a slave, that slave cannot re-register without registering with the master first. Sound good? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10534/#review19269 ----------------------------------------------------------- On April 16, 2013, 12:58 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10534/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 12:58 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This simplifies the master state. > > > Diffs > ----- > > src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed > src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 > src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c > src/webui/master/static/controllers.js > 0f9573b3e325e4ca9ff9ea1467c1815ea16c0fa1 > src/webui/master/static/home.html 847d1b687f1d5a6f11e60b81741d4e22104eddf8 > > Diff: https://reviews.apache.org/r/10534/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
