----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10413/#review19291 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/10413/#comment39963> kill the comment src/slave/slave.cpp <https://reviews.apache.org/r/10413/#comment39964> s/Remvoe/Remove Didn't I see this already? src/slave/slave.cpp <https://reviews.apache.org/r/10413/#comment39966> TODO to this logic to the Executor struct? src/slave/slave.cpp <https://reviews.apache.org/r/10413/#comment39965> const string& if it works nicely in this function src/tests/gc_tests.cpp <https://reviews.apache.org/r/10413/#comment39967> kill meta? src/tests/gc_tests.cpp <https://reviews.apache.org/r/10413/#comment39968> Can we move this inside MesosTest? MesosClusterTest? src/tests/gc_tests.cpp <https://reviews.apache.org/r/10413/#comment39969> Can you try using InSequence to get around this? src/tests/gc_tests.cpp <https://reviews.apache.org/r/10413/#comment39970> Kill the VLOG, ditto above and below. - Ben Mahler On April 16, 2013, 1:45 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10413/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 1:45 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > This is what I have so far. > > We need to fix the TODOs inside runTask() before we can call it complete. > > > Diffs > ----- > > src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 > src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa > src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d > > Diff: https://reviews.apache.org/r/10413/diff/ > > > Testing > ------- > > sudo ./bin/mesos-tests.sh --verbose > --gtest_filter=*GarbageCollectorIntegrationTest.Unschedule* > --gtest_repeat=1000 > > > Thanks, > > Vinod Kone > >
