> On April 17, 2013, 1:19 a.m., Ben Mahler wrote: > > src/tests/gc_tests.cpp, line 699 > > <https://reviews.apache.org/r/10413/diff/3/?file=281489#file281489line699> > > > > Can you try using InSequence to get around this?
I tried it, but it gets ugly because InSequence operates by enforcing the order of expecting statements in a block. Since we capture the return of FUTURE_DISPATCHs in Futures, we need that block to enclose the rest of the test. But this means it also enforces order for all other expectations that follow the FUTURE_DISPATCHs :/ So, I'm leaving it as is. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10413/#review19291 ----------------------------------------------------------- On April 16, 2013, 1:45 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10413/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 1:45 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > This is what I have so far. > > We need to fix the TODOs inside runTask() before we can call it complete. > > > Diffs > ----- > > src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 > src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa > src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d > > Diff: https://reviews.apache.org/r/10413/diff/ > > > Testing > ------- > > sudo ./bin/mesos-tests.sh --verbose > --gtest_filter=*GarbageCollectorIntegrationTest.Unschedule* > --gtest_repeat=1000 > > > Thanks, > > Vinod Kone > >
