----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10531/#review19331 -----------------------------------------------------------
Ship it! src/tests/environment.cpp <https://reviews.apache.org/r/10531/#comment40006> #ifdef guard src/tests/environment.cpp <https://reviews.apache.org/r/10531/#comment40007> s/disabled/Disable/ and end with period. src/tests/environment.cpp <https://reviews.apache.org/r/10531/#comment40008> ditto src/tests/environment.cpp <https://reviews.apache.org/r/10531/#comment40009> ditto src/tests/environment.cpp <https://reviews.apache.org/r/10531/#comment40010> When this #ifdef is false, the generated code is as follows: if (strings::contains(name, "NOHIERARCHY_")) { } So, I think you should either place the entire if inside the #ifdef. - Ben Mahler On April 16, 2013, 9:49 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10531/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 9:49 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > I know that I'm not assigned to this issue, but its causing about 75% of the > test failures that we're seeing in the AMP lab's Jenkins now, so I figured I > would tackle it: > > > This addresses bug MESOS-414. > https://issues.apache.org/jira/browse/MESOS-414 > > > Diffs > ----- > > src/tests/cgroups_tests.cpp 34ae0d2 > src/tests/environment.cpp 3096e5a > > Diff: https://reviews.apache.org/r/10531/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
