BTW: how can I submit my code to the remote repo? I see you guys use git-svn, but I use git to pull the repo out. Is it Ok to merge my branch to trunk and push my commit to remote repo?
Thanks. Guodong On Tue, Apr 23, 2013 at 11:03 AM, Vinod Kone <[email protected]> wrote: > also, it should be safe to manually delete the bad "Review: ...." line from > your log message. > > > On Mon, Apr 22, 2013 at 8:00 PM, Benjamin Mahler > <[email protected]>wrote: > > > That definitely looks like a bug! It looks like your version of > post-review > > might have different output than the version we typically use. What > version > > of post-review are you running? > > > > Here is an expected git log message: > > > > commit 741d67a65713a349450165d5f6cc9f916e04814d > > Author: Benjamin Mahler <[email protected]> > > Date: Mon Apr 15 16:10:44 2013 -0700 > > > > Removed the hostname:port slave map from the Master. > > > > Review: https://reviews.apache.org/r/10534 > > > > > > On Mon, Apr 22, 2013 at 7:52 PM, 王国栋 <[email protected]> wrote: > > > > > Hi all, > > > > > > I am using support/post-review.py to submit my review. But the git log > of > > > my commit seems wrong. I don't know the reason. Now, I can not update > my > > > review request with this tool, since it can not parse the correct > > > review-request-id from git log. > > > > > > The latest 2 commits of my branch is like the following. > > > > > > Author: guodong wang <[email protected]> > > > Date: Tue Apr 23 10:16:39 2013 +0800 > > > > > > add some comments > > > > > > commit a688741ae523abb2d83496daa6eae84809d2f2ad > > > Author: guodong wang <[email protected]> > > > Date: Mon Apr 22 10:41:15 2013 +0800 > > > > > > fix NullPointerException in MesosScheduler when using fairscheduler > > as > > > the underlying scheduler > > > > > > Review: Created new window in existing browser session. > > > > > > I think the green line is not the right log, Is it possible that > > > support/post-review.py generated the wrong Review information ? > > > > > > I think I can modify the git log manually to bypass this problem. But > > still > > > want to know the reason of it. > > > > > > Thanks. :) > > > > > > Guodong > > > > > >
