Hey Guodong, I'm going to get this submitted for you, thanks for the patch!
To make a commit you would need committer access to the project, something
we will definitely be considering as you help out and contribute further!
I looked at your diff and it looked like you made two commits? With
post-reviews, there is a 1:1 commit:review ratio, so ReviewBoard shows your
patch only having the second commit:
diff --git
a/hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
b/hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
index
3074bebee3ea4b907b3e24541490cd0d80dcd3e1..afe401f5265e3d9494af7eace42eec45943184a3
100644
--- a/hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
+++ b/hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
@@ -224,6 +224,7 @@ public class MesosScheduler extends TaskScheduler
implements Scheduler {
// Let the underlying task scheduler do the actual task scheduling.
List<Task> tasks = taskScheduler.assignTasks(taskTracker);
+ // The Hadoop Fair Scheduler is known to return null.
if (tasks != null) {
// Keep track of which TaskTracker contains which tasks.
for (Task task : tasks) {
In the future, we use 'git commit --amend' when looking to update an
existing review. Interactive rebasing also works when your commit is buried
in history.
But don't worry about it this time! I'll fix this up manually :)
On Mon, Apr 22, 2013 at 8:21 PM, 王国栋 <[email protected]> wrote:
> BTW: how can I submit my code to the remote repo?
>
> I see you guys use git-svn, but I use git to pull the repo out. Is it Ok to
> merge my branch to trunk and push my commit to remote repo?
>
> Thanks.
>
> Guodong
>
>
> On Tue, Apr 23, 2013 at 11:03 AM, Vinod Kone <[email protected]> wrote:
>
> > also, it should be safe to manually delete the bad "Review: ...." line
> from
> > your log message.
> >
> >
> > On Mon, Apr 22, 2013 at 8:00 PM, Benjamin Mahler
> > <[email protected]>wrote:
> >
> > > That definitely looks like a bug! It looks like your version of
> > post-review
> > > might have different output than the version we typically use. What
> > version
> > > of post-review are you running?
> > >
> > > Here is an expected git log message:
> > >
> > > commit 741d67a65713a349450165d5f6cc9f916e04814d
> > > Author: Benjamin Mahler <[email protected]>
> > > Date: Mon Apr 15 16:10:44 2013 -0700
> > >
> > > Removed the hostname:port slave map from the Master.
> > >
> > > Review: https://reviews.apache.org/r/10534
> > >
> > >
> > > On Mon, Apr 22, 2013 at 7:52 PM, 王国栋 <[email protected]> wrote:
> > >
> > > > Hi all,
> > > >
> > > > I am using support/post-review.py to submit my review. But the git
> log
> > of
> > > > my commit seems wrong. I don't know the reason. Now, I can not update
> > my
> > > > review request with this tool, since it can not parse the correct
> > > > review-request-id from git log.
> > > >
> > > > The latest 2 commits of my branch is like the following.
> > > >
> > > > Author: guodong wang <[email protected]>
> > > > Date: Tue Apr 23 10:16:39 2013 +0800
> > > >
> > > > add some comments
> > > >
> > > > commit a688741ae523abb2d83496daa6eae84809d2f2ad
> > > > Author: guodong wang <[email protected]>
> > > > Date: Mon Apr 22 10:41:15 2013 +0800
> > > >
> > > > fix NullPointerException in MesosScheduler when using
> fairscheduler
> > > as
> > > > the underlying scheduler
> > > >
> > > > Review: Created new window in existing browser session.
> > > >
> > > > I think the green line is not the right log, Is it possible that
> > > > support/post-review.py generated the wrong Review information ?
> > > >
> > > > I think I can modify the git log manually to bypass this problem. But
> > > still
> > > > want to know the reason of it.
> > > >
> > > > Thanks. :)
> > > >
> > > > Guodong
> > > >
> > >
> >
>
