-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10742/
-----------------------------------------------------------

(Updated April 24, 2013, 7:49 p.m.)


Review request for mesos, Vinod Kone and Ben Mahler.


Changes
-------

Changed construction of Socket instances to be explicit to avoid implicit casts 
to int followed by implicit constructions of Socket (thus creating two separate 
"owning" instances of a socket file descriptor, possibly leading to close being 
called twice). 


Description
-------

See summary.


This addresses bug MESOS-300.
    https://issues.apache.org/jira/browse/MESOS-300


Diffs (updated)
-----

  third_party/libprocess/include/process/socket.hpp 
147939f85cd83356ae9859ed97daf75bf8c6c685 
  third_party/libprocess/src/encoder.hpp 
84e08297d11fc3dc1b040c69290bcc1087628839 
  third_party/libprocess/src/process.cpp 
0a57e8000c3cb9e37aacb485b78a58ba32c7c0ed 

Diff: https://reviews.apache.org/r/10742/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Reply via email to