----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10742/#review19775 -----------------------------------------------------------
third_party/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/10742/#comment40794> I would check for "-1" explicitly. Then I'd set the socket to "-1" just to make sure nothing else can use it later. if (close(s) == -1) { ... } else { s = -1; } - Tobias Weingartner On April 24, 2013, 7:49 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10742/ > ----------------------------------------------------------- > > (Updated April 24, 2013, 7:49 p.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > See summary. > > > This addresses bug MESOS-300. > https://issues.apache.org/jira/browse/MESOS-300 > > > Diffs > ----- > > third_party/libprocess/include/process/socket.hpp > 147939f85cd83356ae9859ed97daf75bf8c6c685 > third_party/libprocess/src/encoder.hpp > 84e08297d11fc3dc1b040c69290bcc1087628839 > third_party/libprocess/src/process.cpp > 0a57e8000c3cb9e37aacb485b78a58ba32c7c0ed > > Diff: https://reviews.apache.org/r/10742/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
