----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10821/#review19835 -----------------------------------------------------------
Looks like you're using 1 space indents, whereas the rest of this file uses 4 spaces. support/post-reviews.py <https://reviews.apache.org/r/10821/#comment40912> It's Libstout (at least as we've named the github repo). support/post-reviews.py <https://reviews.apache.org/r/10821/#comment40913> why the space after '['? support/post-reviews.py <https://reviews.apache.org/r/10821/#comment40919> s/"/' support/post-reviews.py <https://reviews.apache.org/r/10821/#comment40915> Why the conversion back to lists? Can you keep it all in sets, including 'files'? support/post-reviews.py <https://reviews.apache.org/r/10821/#comment40914> ditto support/post-reviews.py <https://reviews.apache.org/r/10821/#comment40917> The boolean operator for lists / sets will ensure it's not empty: if stout and libprocess: ditto below support/post-reviews.py <https://reviews.apache.org/r/10821/#comment40920> Maybe a clearer message for someone new to mesos: "This commit mixes changes to libstout and libprocess, please make separate commits for mesos, libstout, and libprocess." support/post-reviews.py <https://reviews.apache.org/r/10821/#comment40918> Do you want to '\n'.join(stout) and ditto for the rest, is this readable as is? support/post-reviews.py <https://reviews.apache.org/r/10821/#comment40916> s/%s//? - Ben Mahler On April 29, 2013, 12:31 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10821/ > ----------------------------------------------------------- > > (Updated April 29, 2013, 12:31 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu. > > > Description > ------- > > See summary. > > > Diffs > ----- > > support/post-reviews.py 97a1e783d8a8765bd46a9aa3a0cbba61b5212826 > > Diff: https://reviews.apache.org/r/10821/diff/ > > > Testing > ------- > > Tested manually. > > > Thanks, > > Vinod Kone > >
