----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10821/#review19878 -----------------------------------------------------------
This ties post-reviews to Mesos pretty tightly, which isn't horrible but it's definitely a useful tool that I could see other people leveraging outside of Mesos. Why not do this as a git commit hook? I think commit hooks can be arbitrary programs so you can just copy this code to it's own file in the support directory. I acknowledge the benefit of having people using post-reviews getting this functionality "for free" (without having to "install" the commit hook) but we'll have plenty of people who will not use post-reviews so this argument isn't air tight. Instead, we'll need some documentation for developers working with Mesos that says "use post-reviews" and we can also say "and install this commit hook". Here is another thought ... what about making post-reviews automatically do "validation" and make validation pluggable? You could make the default look for validation in the same directory as post-reviews (or something similar) but that would enable pulling post-reviews out of Mesos more easily. And yes, I know there is other work that needs to get done to make post-reviews stand alone, but that's not a good argument for making that process harder in the future. - Benjamin Hindman On April 29, 2013, 12:31 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10821/ > ----------------------------------------------------------- > > (Updated April 29, 2013, 12:31 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu. > > > Description > ------- > > See summary. > > > Diffs > ----- > > support/post-reviews.py 97a1e783d8a8765bd46a9aa3a0cbba61b5212826 > > Diff: https://reviews.apache.org/r/10821/diff/ > > > Testing > ------- > > Tested manually. > > > Thanks, > > Vinod Kone > >
