> On April 26, 2013, 9:56 p.m., Ben Mahler wrote: > > src/slave/cgroups_isolator.cpp, line 822 > > <https://reviews.apache.org/r/10747/diff/2/?file=285041#file285041line822> > > > > is stringify needed? > > Jiang Yan Xu wrote: > Yes because the ternary operator requires the elements on each side of > ':' to be of the same type.
Sort of, it's actually quite complicated in C++: http://stackoverflow.com/a/8535257 But I'm assuming you tried it here ;) - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10747/#review19806 ----------------------------------------------------------- On April 29, 2013, 7:34 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10747/ > ----------------------------------------------------------- > > (Updated April 29, 2013, 7:34 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/cgroups_isolator.hpp f8fabc4e1c3c303b35a76db96b4b2479bd7c8ff8 > src/slave/cgroups_isolator.cpp 8b79da50d8fb0c2c8716dd7d2c734b65c32f60b4 > src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190 > src/slave/process_isolator.cpp 6e2af87d291d7c3448393c1ffa816f7020e2dff6 > src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 > src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 > src/slave/slave.hpp f9d9c2b32983700fb09b266a0abf2a396174ae05 > src/slave/slave.cpp 86a15fce93e6aa3f7a8f9700ef2dcea26fda0d87 > src/tests/reaper_tests.cpp 0809c1ff17eb949beb1bdd922fdced022aa202f3 > > Diff: https://reviews.apache.org/r/10747/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
