> On April 26, 2013, 10:40 p.m., Vinod Kone wrote: > > src/slave/cgroups_isolator.cpp, lines 772-774 > > <https://reviews.apache.org/r/10747/diff/1-2/?file=283980#file283980line772> > > > > one arg per line.
Sorry overlooked this one... Addressed in https://reviews.apache.org/r/10746/ > On April 26, 2013, 10:40 p.m., Vinod Kone wrote: > > src/slave/cgroups_isolator.cpp, lines 818-823 > > <https://reviews.apache.org/r/10747/diff/1-2/?file=283980#file283980line818> > > > > This reads different here and in slave.cpp. > > > > The reason I wanted you to print status here is because for > > cgroupsisolator there is a delay between when reaped() is called and when > > executorTerminated() is sent to the slave. And I wondered if the exit > > status would be useful if we ever failed to send executorTerminated (e.g., > > FATAL error in cgroups cleanup). > > > > To sum, either we should make the log message consistent or just not > > print the status. Thoughts? > > > > As discussed offline, we keep it as is. > On April 26, 2013, 10:40 p.m., Vinod Kone wrote: > > src/slave/reaper.hpp, lines 62-63 > > <https://reviews.apache.org/r/10747/diff/1-2/?file=283983#file283983line62> > > > > s/, / and the process hasn't been reaped yet/ ? Addressed in https://reviews.apache.org/r/10746/ > On April 26, 2013, 10:40 p.m., Vinod Kone wrote: > > src/slave/reaper.hpp, line 60 > > <https://reviews.apache.org/r/10747/diff/1-2/?file=283983#file283983line60> > > > > s/ a Future in a failed state/failed Future/ Addressed in https://reviews.apache.org/r/10746/ > On April 26, 2013, 10:40 p.m., Vinod Kone wrote: > > src/slave/reaper.hpp, line 72 > > <https://reviews.apache.org/r/10747/diff/1-2/?file=283983#file283983line72> > > > > s/of/in/ ? > > > > If you like, you can kill the second sentence altogether. Addressed in https://reviews.apache.org/r/10746/ - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10747/#review19808 ----------------------------------------------------------- On April 29, 2013, 7:34 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10747/ > ----------------------------------------------------------- > > (Updated April 29, 2013, 7:34 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/cgroups_isolator.hpp f8fabc4e1c3c303b35a76db96b4b2479bd7c8ff8 > src/slave/cgroups_isolator.cpp 8b79da50d8fb0c2c8716dd7d2c734b65c32f60b4 > src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190 > src/slave/process_isolator.cpp 6e2af87d291d7c3448393c1ffa816f7020e2dff6 > src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 > src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 > src/slave/slave.hpp f9d9c2b32983700fb09b266a0abf2a396174ae05 > src/slave/slave.cpp 86a15fce93e6aa3f7a8f9700ef2dcea26fda0d87 > src/tests/reaper_tests.cpp 0809c1ff17eb949beb1bdd922fdced022aa202f3 > > Diff: https://reviews.apache.org/r/10747/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
