----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10896/#review20295 -----------------------------------------------------------
This review really screams for an os::sysctl helper. I've got something in mind I'll send your way. third_party/libprocess/third_party/stout/include/stout/os/osx.hpp <https://reviews.apache.org/r/10896/#comment41830> s/pointer,/pointer/ third_party/libprocess/third_party/stout/include/stout/os/osx.hpp <https://reviews.apache.org/r/10896/#comment41832> Two thoughts: (1) Why not provide __FILE__ and __LINE__ so people could easily find the context? (2) Why not express in English what you believe to be wrong rather than in code (which I can clearly read once I find the __FILE__ and __LINE__). For example: << "Failed to determine the maximum number of processes allowed in the system, expecting output to be " << sizeof(maximumProcesses) << " bytes but instead output was " << resultSize << " bytes"; third_party/libprocess/third_party/stout/include/stout/os/osx.hpp <https://reviews.apache.org/r/10896/#comment41831> delete[] third_party/libprocess/third_party/stout/include/stout/os/osx.hpp <https://reviews.apache.org/r/10896/#comment41878> delete[] - Benjamin Hindman On May 2, 2013, 1:40 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10896/ > ----------------------------------------------------------- > > (Updated May 2, 2013, 1:40 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. > > > Diffs > ----- > > third_party/libprocess/third_party/stout/include/stout/os/osx.hpp > PRE-CREATION > third_party/libprocess/third_party/stout/tests/os_tests.cpp > 047778d05ebbbefd85e4a163dbb6ab8445edfb7f > > Diff: https://reviews.apache.org/r/10896/diff/ > > > Testing > ------- > > make check on OSX and Linux. > > > Thanks, > > Ben Mahler > >
