> On May 8, 2013, 5:47 p.m., Benjamin Hindman wrote: > > This review really screams for an os::sysctl helper. I've got something in > > mind I'll send your way.
Cool, I can take this on top of these changes if you want to pass it over. Will be discarding and sending out a separate chain for this due to the restructuring. > On May 8, 2013, 5:47 p.m., Benjamin Hindman wrote: > > third_party/libprocess/third_party/stout/include/stout/os/osx.hpp, line 85 > > <https://reviews.apache.org/r/10896/diff/1/?file=286972#file286972line85> > > > > delete[] Good catch, thanks! > On May 8, 2013, 5:47 p.m., Benjamin Hindman wrote: > > third_party/libprocess/third_party/stout/include/stout/os/osx.hpp, line 99 > > <https://reviews.apache.org/r/10896/diff/1/?file=286972#file286972line99> > > > > delete[] Phew, thanks for catching this! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10896/#review20295 ----------------------------------------------------------- On May 2, 2013, 1:40 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10896/ > ----------------------------------------------------------- > > (Updated May 2, 2013, 1:40 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. > > > Diffs > ----- > > third_party/libprocess/third_party/stout/include/stout/os/osx.hpp > PRE-CREATION > third_party/libprocess/third_party/stout/tests/os_tests.cpp > 047778d05ebbbefd85e4a163dbb6ab8445edfb7f > > Diff: https://reviews.apache.org/r/10896/diff/ > > > Testing > ------- > > make check on OSX and Linux. > > > Thanks, > > Ben Mahler > >
