> On May 24, 2013, 1:52 a.m., Benjamin Hindman wrote: > > src/detector/detector.cpp, line 426 > > <https://reviews.apache.org/r/11366/diff/1/?file=296193#file296193line426> > > > > I don't know what you mean by "Try again when we reconnect.". If I > > understand correctly if we get a ZNONODE we won't have put a watch in place > > which means we'll just sit idle until we reconnect, which could be a very > > long time.
The comment is wrong. I should've said try when there is an update on the path. I could write a test to verify, but do you happen to know what are the semantics of a "watch" when zk->getChildren(/path/to/mesos) fails because "/path" doesn't exist? Do we get an updated() callback when /path (and recursively /path/to and /path/to/mesos) gets created? if yes, we should be ok right? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11366/#review20975 ----------------------------------------------------------- On May 24, 2013, 1:03 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11366/ > ----------------------------------------------------------- > > (Updated May 24, 2013, 1:03 a.m.) > > > Review request for mesos, Benjamin Hindman and Jiang Yan Xu. > > > Description > ------- > > This is likely a short term fix pending Yan's refactor of detector. > > 2 changes: > 1) Fixed a bug in zookeeper->create(). > 2) Removed create for non-contending detectors. > > > This addresses bug mesos-409. > https://issues.apache.org/jira/browse/mesos-409 > > > Diffs > ----- > > src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e > src/zookeeper/zookeeper.hpp 99e689e5178845480b2426e694d18c5257234166 > src/zookeeper/zookeeper.cpp 267c38a2922f114519ffaf4f0bdce74d22fc1506 > > Diff: https://reviews.apache.org/r/11366/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
