----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11366/#review21004 -----------------------------------------------------------
src/detector/detector.cpp <https://reviews.apache.org/r/11366/#comment43461> I think this belongs inside zookeeper.cpp:ZooKeeper#create so that we guard ourselves for all callsites. src/zookeeper/zookeeper.cpp <https://reviews.apache.org/r/11366/#comment43462> As commented above, I would do the exists() checks inside this loop (and stop doing them after exists() returns false for the first time as an optimization). - Raul Gutierrez Segales On May 24, 2013, 4:23 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11366/ > ----------------------------------------------------------- > > (Updated May 24, 2013, 4:23 p.m.) > > > Review request for mesos, Benjamin Hindman, Bill Farner, Ben Mahler, and Raul > Gutierrez Segales. > > > Description > ------- > > This is likely a short term fix pending Yan's refactor of detector. > > 2 changes: > 1) Fixed a bug in zookeeper->create(). > 2) Removed create for non-contending detectors. > > > This addresses bug mesos-409. > https://issues.apache.org/jira/browse/mesos-409 > > > Diffs > ----- > > src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e > src/zookeeper/zookeeper.hpp 99e689e5178845480b2426e694d18c5257234166 > src/zookeeper/zookeeper.cpp 267c38a2922f114519ffaf4f0bdce74d22fc1506 > > Diff: https://reviews.apache.org/r/11366/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
