> On May 30, 2013, 3:52 a.m., Raul Gutierrez Segales wrote:
> > src/zookeeper/zookeeper.cpp, line 533
> > <https://reviews.apache.org/r/11366/diff/4/?file=298812#file298812line533>
> >
> > Why not os::dirname? (sure there is a good reason, just curious)
dirname("/a/b/") returns "/a". We want "/a/b". Makes sense?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11366/#review21171
-----------------------------------------------------------
On May 30, 2013, 3:44 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11366/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 3:44 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bill Farner, Ben Mahler, and Raul
> Gutierrez Segales.
>
>
> Description
> -------
>
> This is likely a short term fix pending Yan's refactor of detector.
>
> 2 changes:
> 1) Fixed a bug in zookeeper->create().
> 2) Removed create for non-contending detectors.
>
>
> This addresses bug mesos-409.
> https://issues.apache.org/jira/browse/mesos-409
>
>
> Diffs
> -----
>
> src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e
> src/tests/zookeeper_tests.cpp 77a5ab259e907f8df7ae88271da467b673895a5b
> src/zookeeper/zookeeper.hpp 99e689e5178845480b2426e694d18c5257234166
> src/zookeeper/zookeeper.cpp 267c38a2922f114519ffaf4f0bdce74d22fc1506
>
> Diff: https://reviews.apache.org/r/11366/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
