----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11366/#review21354 -----------------------------------------------------------
src/detector/detector.cpp <https://reviews.apache.org/r/11366/#comment44267> Why the extra check if create is going to do it for us? src/zookeeper/zookeeper.cpp <https://reviews.apache.org/r/11366/#comment44273> I propose that the core ZooKeeper::create function works as follows: If we're trying to create '/a/b/c/d' we should start by checking if '/a/b/c/d' exists. If it does (and we aren't being asked to create an ephemeral child), we should just return. If it doesn't exist and we've been asked to do the create "recursively", we should check if '/a/b/c' exists, and if not then '/a/b', and if not '/a', etc. You might even be able to just do this recursively with create as it is today (modifying arguments as necessary). - Benjamin Hindman On May 30, 2013, 6:39 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11366/ > ----------------------------------------------------------- > > (Updated May 30, 2013, 6:39 p.m.) > > > Review request for mesos, Benjamin Hindman, Bill Farner, Ben Mahler, and Raul > Gutierrez Segales. > > > Description > ------- > > This is likely a short term fix pending Yan's refactor of detector. > > 2 changes: > 1) Fixed a bug in zookeeper->create(). > 2) Removed create for non-contending detectors. > > > This addresses bug mesos-409. > https://issues.apache.org/jira/browse/mesos-409 > > > Diffs > ----- > > configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e > src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e > src/tests/zookeeper_tests.cpp 77a5ab259e907f8df7ae88271da467b673895a5b > src/zookeeper/zookeeper.hpp 99e689e5178845480b2426e694d18c5257234166 > src/zookeeper/zookeeper.cpp 267c38a2922f114519ffaf4f0bdce74d22fc1506 > > Diff: https://reviews.apache.org/r/11366/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
