----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11556/#review21259 -----------------------------------------------------------
Ship it! src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/11556/#comment44133> Aha. I see that you changed the comment here. Ignore my comment in the previous review. src/slave/reaper.hpp <https://reviews.apache.org/r/11556/#comment44134> why not failed future? src/slave/slave.cpp <https://reviews.apache.org/r/11556/#comment44135> Hmm.. Not sure I like changing the argument. Can you make arg const Option<int> status and use local variable "status_"? - Vinod Kone On May 30, 2013, 11:11 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11556/ > ----------------------------------------------------------- > > (Updated May 30, 2013, 11:11 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > Rebased against master. Previous review received "shipit"s but got lost. > > > Diffs > ----- > > src/slave/cgroups_isolator.hpp 7b8270d0b0f94a71da12bc123d39b44c40c3f7ed > src/slave/cgroups_isolator.cpp 9b3a3a5dfec27a119fdd47a88f016e21470eb88d > src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190 > src/slave/process_isolator.cpp d4f7b7603452e7226189899aca7e3c94e537829f > src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 > src/slave/reaper.cpp 1d826d1b5fe1048b03662a1e9d12b18371e5c88f > src/slave/slave.hpp 26dc96e5f2fdc0711fc49a9ea80b7f037bf93c29 > src/slave/slave.cpp e905ab3cd965002592c1f70c85ea3378ac8982b0 > src/tests/reaper_tests.cpp fbb6066652c0f36c0a8fd9b0c4dac7e0240a5210 > > Diff: https://reviews.apache.org/r/11556/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
