----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11549/#review21325 -----------------------------------------------------------
src/tests/status_update_manager_tests.cpp <https://reviews.apache.org/r/11549/#comment44231> Great! src/tests/status_update_manager_tests.cpp <https://reviews.apache.org/r/11549/#comment44232> You won't get this yet, please move down. src/tests/status_update_manager_tests.cpp <https://reviews.apache.org/r/11549/#comment44233> EXPECT_CALL(sched, statusUpdate ...) should come here. src/tests/status_update_manager_tests.cpp <https://reviews.apache.org/r/11549/#comment44234> Please add a comment explaining this set up for the rest of the test. src/tests/status_update_manager_tests.cpp <https://reviews.apache.org/r/11549/#comment44235> So can 'update' and 'update2' be moved down here? Does Clock::advance act as the event which sends those two updates? If not, can you move one of the AWAIT_READY(update*) calls up? - Benjamin Hindman On May 30, 2013, 9:59 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11549/ > ----------------------------------------------------------- > > (Updated May 30, 2013, 9:59 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > See summary. > > > This addresses bug MESOS-482. > https://issues.apache.org/jira/browse/MESOS-482 > > > Diffs > ----- > > src/slave/status_update_manager.hpp > 795e74c2b88a071eb7ba720118e06077b6e41238 > src/slave/status_update_manager.cpp > 9e9e4e2a47a609d65ed69a57de595852144a86c8 > src/tests/status_update_manager_tests.cpp > 61ccfcc8165337d02af5641884beee45a2aaa065 > > Diff: https://reviews.apache.org/r/11549/diff/ > > > Testing > ------- > > make check > > GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*TerminateEmptyStream*" > --verbose --gtest_repeat=1000 --gtest_break_on_failure > > > Thanks, > > Vinod Kone > >
