> On June 3, 2013, 8:57 p.m., Charles Reiss wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, line 519 > > <https://reviews.apache.org/r/11161/diff/2/?file=300044#file300044line519> > > > > I think if the offer contains something like > > 'ports:[2048-2048,3192-65535]', this might choose unoffered ports.
Good point. I'll resolve this. > On June 3, 2013, 8:57 p.m., Charles Reiss wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, line 522 > > <https://reviews.apache.org/r/11161/diff/2/?file=300044#file300044line522> > > > > A comment to explain why there can be duplicate ports would be nice. (I > > assume it's that Mesos can process task completions before the scheduler > > does) If you try and launch >1 task trackers from the same slave, you need to ensure they aren't sharing the same ports. It can happen when you launch a small task tracker and then launch another on the same slave afterwards. This is a common pattern when you're running multiple Hadoop jobs simultaneously. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11161/#review21353 ----------------------------------------------------------- On June 3, 2013, 5:59 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11161/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 5:59 p.m.) > > > Review request for mesos. > > > Description > ------- > > Don't accept offers on the same host/port. > > We'll try to find a port combination that hasn't already been used to > launch a TaskTracker. > > Review: https://reviews.apache.org/r/11161/ > > > Diffs > ----- > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > afe401f5265e3d9494af7eace42eec45943184a3 > > Diff: https://reviews.apache.org/r/11161/diff/ > > > Testing > ------- > > Used in production at airbnb. > > > Thanks, > > Brenden Matthews > >
