----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11161/#review21741 -----------------------------------------------------------
I still don't understand why the Hadoop scheduler would get an offer with ports that are currently in use by a task tracker? If thats the case, it is a bug in Mesos. Some logs indicating this problem would be nice to diagnose the real issue here. hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java <https://reviews.apache.org/r/11161/#comment44924> Isn't 'begin' always equal to 'range.getBegin()' and 'end' always equal to 'range.getEnd()' ? hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java <https://reviews.apache.org/r/11161/#comment44926> I don't like this because ports array could get very big, if we include every free port in the list. hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java <https://reviews.apache.org/r/11161/#comment44930> why sort? - Vinod Kone On June 11, 2013, 8:56 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11161/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 8:56 p.m.) > > > Review request for mesos. > > > Description > ------- > > Don't accept offers on the same host/port. > > We'll try to find a port combination that hasn't already been used to > launch a TaskTracker. > > Review: https://reviews.apache.org/r/11161/ > > > Diffs > ----- > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > afe401f5265e3d9494af7eace42eec45943184a3 > > Diff: https://reviews.apache.org/r/11161/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
