-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11366/#review21389
-----------------------------------------------------------

Ship it!



configure.ac
<https://reviews.apache.org/r/11366/#comment44321>

    Intended?



src/zookeeper/zookeeper.cpp
<https://reviews.apache.org/r/11366/#comment44322>

    Well, deletion seems dangerous in the face of many detectors operating at 
once on the same path, no?


- Ben Mahler


On June 4, 2013, 12:03 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11366/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 12:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bill Farner, Ben Mahler, and Raul 
> Gutierrez Segales.
> 
> 
> Description
> -------
> 
> This is likely a short term fix pending Yan's refactor of detector.
> 
> 2 changes:
> 1) Fixed a bug in zookeeper->create().
> 2) Removed create for non-contending detectors.
> 
> 
> This addresses bug mesos-409.
>     https://issues.apache.org/jira/browse/mesos-409
> 
> 
> Diffs
> -----
> 
>   configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e 
>   src/tests/zookeeper_tests.cpp 77a5ab259e907f8df7ae88271da467b673895a5b 
>   src/zookeeper/zookeeper.hpp 99e689e5178845480b2426e694d18c5257234166 
>   src/zookeeper/zookeeper.cpp 267c38a2922f114519ffaf4f0bdce74d22fc1506 
> 
> Diff: https://reviews.apache.org/r/11366/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to