----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11641/#review21530 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/11641/#comment44567> What's the different between "CPUs used" and "CPU resources allocated" ... if they are the same thing we should use the same language. Also, as long as we are cleaning up the stats names, it would be nice if the resource "name" matched the resource itself, i.e., s/cpu/cpus, s/memory/mem, etc. But this might be too much to ask for given existing users. (I could see cpu_user_time_secs and cpu_system_time_secs being just 'cpu' though). Thoughts? src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/11641/#comment44569> +1 to 'mem'. src/slave/monitor.cpp <https://reviews.apache.org/r/11641/#comment44571> How is this not going to break existing users? src/slave/monitor.cpp <https://reviews.apache.org/r/11641/#comment44570> It's a little unfortunate that we have to do process::statistics everywhere. :( It makes the code much less readable. If you did 'using process::statistics;' above could you reference statistics via '::statistics' (i.e., ::statistics->archive(...) and ::statistics->set(...), etc.)? src/tests/isolator_tests.cpp <https://reviews.apache.org/r/11641/#comment44572> s/memory/mem - Benjamin Hindman On June 4, 2013, 10:14 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11641/ > ----------------------------------------------------------- > > (Updated June 4, 2013, 10:14 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This adds allocation information into the resource usage endpoint. > This also splits up "cpu_time" into "cpu_system_time_secs" and > "cpu_user_time_secs". > > > This addresses bugs MESOS-432 and MESOS-472. > https://issues.apache.org/jira/browse/MESOS-432 > https://issues.apache.org/jira/browse/MESOS-472 > > > Diffs > ----- > > include/mesos/mesos.proto ece6559e4c8a3e943833be27c5fb0f02910d2d20 > src/slave/cgroups_isolator.hpp 7b8270d0b0f94a71da12bc123d39b44c40c3f7ed > src/slave/cgroups_isolator.cpp 9b3a3a5dfec27a119fdd47a88f016e21470eb88d > src/slave/monitor.cpp 5de1c15c78194ab9ec49c30b9abfb9a6d3e16344 > src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190 > src/slave/process_isolator.cpp d4f7b7603452e7226189899aca7e3c94e537829f > src/tests/isolator_tests.cpp aae8b2f78d6a2d5e4e3f31cce4380ef5197f4f5d > src/tests/monitor_tests.cpp 53920a0d7bdc69071b64c8d315c008d501e27777 > > Diff: https://reviews.apache.org/r/11641/diff/ > > > Testing > ------- > > Updated the tests, make check on OSX and Linux. > > > Thanks, > > Ben Mahler > >
