----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11694/#review21560 -----------------------------------------------------------
Ship it! Still a "Ship It", just another comment. src/slave/slave.cpp <https://reviews.apache.org/r/11694/#comment44604> One more thing, I'd love to see a comment here clearly calling out these semantics, possibly with a TODO that says these semantics will be removed in the future. - Benjamin Hindman On June 6, 2013, 8:39 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11694/ > ----------------------------------------------------------- > > (Updated June 6, 2013, 8:39 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.hpp 26dc96e5f2fdc0711fc49a9ea80b7f037bf93c29 > src/slave/slave.cpp 8ce1646f2f804bc8dc20506d11078191f0274654 > > Diff: https://reviews.apache.org/r/11694/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
