> On June 7, 2013, 5:22 a.m., Benjamin Hindman wrote: > > Really really really nice work Vinod. This is super clean and IMHO easy to > > reason about. Nice to have some clean semantics re: task lifecycle.
thanks! someone nudged me this way :) > On June 7, 2013, 5:22 a.m., Benjamin Hindman wrote: > > src/slave/slave.hpp, line 339 > > <https://reviews.apache.org/r/11694/diff/1/?file=301598#file301598line339> > > > > Food for thought: s/removeTask/completeTask/ done > On June 7, 2013, 5:22 a.m., Benjamin Hindman wrote: > > src/slave/slave.hpp, line 345 > > <https://reviews.apache.org/r/11694/diff/1/?file=301598#file301598line345> > > > > Ha, BenM and I had a conversation today about the use of the word > > 'pending' in Hadoop (i.e., does pendingMaps/Reduces() mean maps/reduces > > that we still need to launch or maps/reduces that have been launched but > > haven't completed yet?). I think that the same thing applies here. Maybe > > s/pendingTasks/unfinishedTasks/ or better incompleteTasks (since the ring > > buffer is "completedTasks")? IMHO it's easier to interpret > > 'incompleteTasks' as implying _both_ tasks that are queued (what some might > > consider "pending") and those that are already launched. went with incompleteTasks. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11694/#review21559 ----------------------------------------------------------- On June 6, 2013, 8:39 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11694/ > ----------------------------------------------------------- > > (Updated June 6, 2013, 8:39 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.hpp 26dc96e5f2fdc0711fc49a9ea80b7f037bf93c29 > src/slave/slave.cpp 8ce1646f2f804bc8dc20506d11078191f0274654 > > Diff: https://reviews.apache.org/r/11694/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
