> On June 11, 2013, 8:26 p.m., Ben Mahler wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, line 53 > > <https://reviews.apache.org/r/11130/diff/2/?file=300042#file300042line53> > > > > There have been several internal discussions at Twitter with respect to > > JVM memory overhead. There was no clear answer but one recommendation was > > to set it to 5-10% of the heap size. > > > > So I would be ok with this being: > > > > JVM_MEM_OVERHEAD_PERCENT = 0.1; > > > > and then > > > > private static final int TASKTRACKER_MEM = > > TASKTRACKER_JVM_HEAP * (1.0 + JVM_MEM_OVERHEAD); > > > > Thoughts? > >
That's probably a better approach. I'll update it shortly. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11130/#review21735 ----------------------------------------------------------- On June 11, 2013, 8:16 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11130/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 8:16 p.m.) > > > Review request for mesos. > > > Description > ------- > > Allow JVM memory vars to be configured. > > Review: https://reviews.apache.org/r/11130 > > > Diffs > ----- > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > afe401f5265e3d9494af7eace42eec45943184a3 > > Diff: https://reviews.apache.org/r/11130/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
