> On June 14, 2013, 8:51 p.m., Ben Mahler wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, line 461 > > <https://reviews.apache.org/r/11130/diff/6/?file=303789#file303789line461> > > > > Why did you want to configure this one? Just looking to understand the > > context.
I think it's pretty important to be able to adjust the tasktracker heap size. It's something that needs to be tuned to suit your particular application. > On June 14, 2013, 8:51 p.m., Ben Mahler wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, line 447 > > <https://reviews.apache.org/r/11130/diff/6/?file=303789#file303789line447> > > > > Let's hold off on adding another configuration variable, until we see > > whether 10% has issues. Ultimately, I think this is something that the > > scheduler should know rather than the users. I've been running with this as a default so far with good results. I feel like there's a Hadoop convention to allow configuration of most 'knobs', and this seems like an important one. I'm not opposed to just leaving it as a default, but I also don't think we're doing harm by allowing it to be configured. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11130/#review21919 ----------------------------------------------------------- On June 11, 2013, 9:20 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11130/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 9:20 p.m.) > > > Review request for mesos. > > > Description > ------- > > Allow JVM memory vars to be configured. > > Review: https://reviews.apache.org/r/11130 > > > Diffs > ----- > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > afe401f5265e3d9494af7eace42eec45943184a3 > > Diff: https://reviews.apache.org/r/11130/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
