----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11814/#review21833 -----------------------------------------------------------
After doing some digging, I'm guessing you made this change because of the links present on the /frameworks/FID page of the webui? Can you update the review description to comment on what the issue was that prompted this change? It would be much appreciated and helps us understand the context behind the change. src/webui/master/static/controllers.js <https://reviews.apache.org/r/11814/#comment45103> Rather than setting the executor ID here (which is somewhat misleading since the task does not have an executor specified), it would be better to adjust framework.html to correctly set the link. You can do this with the ui-if directive (see browse.html) for an example. This is relevant regardless of whether I correctly guessed the issue. :) - Ben Mahler On June 12, 2013, 2:21 a.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11814/ > ----------------------------------------------------------- > > (Updated June 12, 2013, 2:21 a.m.) > > > Review request for mesos. > > > Description > ------- > > Fix executor IDs in web UI. > > Review: https://reviews.apache.org/r/11814 > > > Diffs > ----- > > src/webui/master/static/controllers.js > 0ea77cec2d6ca520e69fd74eb56fe05d32b711bd > src/webui/master/static/framework.html > c2d770bc40fae90ed6e3bb6b4b37cad551d69956 > > Diff: https://reviews.apache.org/r/11814/diff/ > > > Testing > ------- > > > Thanks, > > Brenden Matthews > >
