----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11814/#review22376 -----------------------------------------------------------
Ship it! Go ahead and commit this once the comment is updated below. Can you adjust the commit message? "Fixed broken links in the webui for command executor tasks." src/webui/master/static/controllers.js <https://reviews.apache.org/r/11814/#comment45903> I'm ok with this as a hack for now. Can you update the comment: // If the executor ID is empty, this is a command executor with an internal executor ID generated from the task ID. // TODO(brenden): Remove this once https://issues.apache.org/jira/browse/MESOS-527 is fixed. - Ben Mahler On June 13, 2013, 4:42 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11814/ > ----------------------------------------------------------- > > (Updated June 13, 2013, 4:42 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Fix executor IDs in web UI. > > Some frameworks don't report an executor ID, but have a task ID. As a > workaround, we can use the task ID when the executor ID is empty. > > Review: https://reviews.apache.org/r/11814 > > > Diffs > ----- > > src/webui/master/static/controllers.js > 0ea77cec2d6ca520e69fd74eb56fe05d32b711bd > src/webui/master/static/framework.html > c2d770bc40fae90ed6e3bb6b4b37cad551d69956 > > Diff: https://reviews.apache.org/r/11814/diff/ > > > Testing > ------- > > Tested by test driving the web UI. > > > Thanks, > > Brenden Matthews > >
