----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11895/#review21995 -----------------------------------------------------------
Ship it! Move to osx namespace as discussed. 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp <https://reviews.apache.org/r/11895/#comment45314> s/1/5/ 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp <https://reviews.apache.org/r/11895/#comment45321> delete[] 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp <https://reviews.apache.org/r/11895/#comment45322> dead? 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp <https://reviews.apache.org/r/11895/#comment45326> const&? 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp <https://reviews.apache.org/r/11895/#comment45324> Do you want to hide this? 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp <https://reviews.apache.org/r/11895/#comment45325> const? 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp <https://reviews.apache.org/r/11895/#comment45327> const&? - Ben Mahler On June 15, 2013, 9:50 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11895/ > ----------------------------------------------------------- > > (Updated June 15, 2013, 9:50 p.m.) > > > Review request for mesos and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 84062a0e1dfe4ec04bac7cac5ebaac4b945eb66e > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 047778d05ebbbefd85e4a163dbb6ab8445edfb7f > > Diff: https://reviews.apache.org/r/11895/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
