> On June 17, 2013, 7:03 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp, line 79
> > <https://reviews.apache.org/r/11895/diff/1/?file=306602#file306602line79>
> >
> >     s/1/5/

Thanks!


> On June 17, 2013, 7:03 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp, line 90
> > <https://reviews.apache.org/r/11895/diff/1/?file=306602#file306602line90>
> >
> >     delete[]

Thanks!


> On June 17, 2013, 7:03 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp, lines 93-100
> > <https://reviews.apache.org/r/11895/diff/1/?file=306602#file306602line93>
> >
> >     dead?

Awesome!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11895/#review21995
-----------------------------------------------------------


On June 17, 2013, 7:41 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11895/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 7:41 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 84062a0e1dfe4ec04bac7cac5ebaac4b945eb66e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 047778d05ebbbefd85e4a163dbb6ab8445edfb7f 
> 
> Diff: https://reviews.apache.org/r/11895/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to